search

CDCgov / mycosnp-nf

CDCgov/mycosnp-nf
Apache License 2.0
36 stars 33 forks source link

add fks1_hs3 and change output name for snpeffr #112

Closed mrajeev08 closed 10 months ago

mrajeev08 commented 10 months ago

Hi @hseabolt,

MDB would like to update the default for the --position parameter in snpeffr and also update the output name from that module.

I based this PR off of the dev branch, but just wanted to confirm that's how we're doing development work ahead of a new release?

Thanks, Mal

hseabolt commented 10 months ago

You're correct, we will want to base merges to dev branch, thoroughly test/validate them, and lastly merge with master. The two changes here look fine to me, so I'm approving this merge.