CDCgov / mycosnp-nf

CDCgov/mycosnp-nf
Apache License 2.0
37 stars 33 forks source link

QC step to exclude failed samples (based on CDC recommended FASTQ QC thresholds) from analysis. #125

Open jessres opened 1 week ago

jessres commented 1 week ago

Is your feature request related to a problem? Please describe. We ran into an issue where too many low coverage samples resulted in a pretty much empty vcf-to-fasta file, affecting the results of the passing samples and being unable to generate a phylogenetic tree. Further investigation shows that even 2 - 3 very low coverage samples can affect the accuracy of the phylogenetic tree. Describe the solution you'd like We would like to see failed low coverage samples be removed before vcf-to-fasta generation so that only passing samples are used for the core genome and results of the phylogenetic tree are accurate. QC results should still include all samples.

Describe alternatives you've considered Alternatively, we have considered re-analyzing the run with just passing samples however, this negatively impacts our automated workflow and TAT.

Additional context Add any other context or screenshots about the feature request here.

zmudge3 commented 5 days ago

Hi @jessres, thanks for your request. I'm seeing three potential solutions to this issue:

jessres commented 4 days ago

Hello @zmudge3 we appreciate such a quick response! Ideally option 3 is exactly what we are looking for. When do you expect v1.6 to be released?

zmudge3 commented 4 days ago

Got it, thank you. We're hoping to have it released by the end of the year.