CDCgov / opencdc

This is the repository for the openCDC web site. Entire site is generated from data files describing CDC Open Technology types for data, api, code, and events. All CDC programs are welcome to submit pull requests with updates and new items useful to the public health open source community.
https://open.cdc.gov
Apache License 2.0
15 stars 28 forks source link

Update code.yml #32

Closed mlamtahri closed 5 years ago

mlamtahri commented 5 years ago

Added Epi Info logo.

leebrian commented 5 years ago

Cool. Thanks. What about "Epi Info?" Should that be "EpiInfo" or "Epi-Info". Currently it shows up as #Epi info. Which is fine if you're ok with it, but may be disorienting to users. It looks like there's posts using both "#EpiInfo" and "#Epi-Info" https://twitter.com/search?q=%23EpiInfo&src=typd

mlamtahri commented 5 years ago

Brian, I'm not able to add the Epi info logo to the directory assets/img. Below is the message that I get when I try to upload the image to GitHub. [cid:image001.jpg@01D4B7D4.2954F390] Attached is the image I'm trying to upload.

Also, I will change the tag "Epi Info" to "EpiInfo". Thank you Mohammed lamtahri

From: Brian Lee notifications@github.com Sent: Tuesday, January 29, 2019 12:51 PM To: CDCgov/opencdc opencdc@noreply.github.com Cc: Lamtahri, Mohammed (CDC/DDPHSS/CSELS/DHIS) vwm5@cdc.gov; Author author@noreply.github.com Subject: Re: [CDCgov/opencdc] Update code.yml (#32)

Cool. Thanks. What about "Epi Info?" Should that be "EpiInfo" or "Epi-Info". Currently it shows up as #Epi info. Which is fine if you're ok with it, but may be disorienting to users. It looks like there's posts using both "#EpiInfo" and "#Epi-Info" https://twitter.com/search?q=%23EpiInfo&src=typd

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/CDCgov/opencdc/pull/32#issuecomment-458639273, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXRFP4F-IAtDn894-FAK3kMtHRqWxmKCks5vIIoRgaJpZM4aYkzz.

leebrian commented 5 years ago

I didn't see the message or image you reference. Are you adding the image to the patch-2 branch? You should be able to upload the new image. Would you please describe the steps you take to upload?

If you're using the web interface, you'll need to be directly in your branch folder on https://github.com/mlamtahri/opencdc/tree/patch-2/assets/img using your browser.

If you're getting this error, it's usually because the browser is navigated to the master branch (where few people have push permissions) image

mlamtahri commented 5 years ago

Sorry I was using the wrong branch…I’m able to upload image. Thank you ML

From: Brian Lee notifications@github.com Sent: Tuesday, January 29, 2019 1:22 PM To: CDCgov/opencdc opencdc@noreply.github.com Cc: Lamtahri, Mohammed (CDC/DDPHSS/CSELS/DHIS) vwm5@cdc.gov; Author author@noreply.github.com Subject: Re: [CDCgov/opencdc] Update code.yml (#32)

I didn't see the message or image you reference. Are you adding the image to the patch-2 branch? You should be able to upload the new image. Would you please describe the steps you take to upload?

If you're using the web interface, you'll need to be directly in your branch folder on https://github.com/mlamtahri/opencdc/tree/patch-2/assets/img using your browser.

If you're getting this error, it's usually because the browser is navigated to the master branch (where few people have push permissions) [image]https://user-images.githubusercontent.com/307968/51930542-b128c980-23af-11e9-981b-f74bdd47f3aa.png

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/CDCgov/opencdc/pull/32#issuecomment-458650374, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXRFP_XrJAbdUGUroUZJhVcGmhakOkTFks5vIJFdgaJpZM4aYkzz.