This turns on the GitHub CI for TEFCA Viewer. It largely follows the structure of the ecr-viewer's config, with the exception of the cypress e2e testing.
This PR also removes the current, stale integration tests from tefca-viewer's repo to avoid an error. I think next step will need to be to determine if we want to implement cypress e2e and whether we prefer what is done that way in lieu of integration tests, since that seems to be the direction the ecr-viewer went.
Another note: I don't know if I fully understand the symlink stuff. I thought we had this shared directory so that TEFCA could use it, but if it is, it seems to be used differently to how ecr-viewer has it set up. I've left it commented out for now, but I don't know if we need to update this based on how we use it. I also know we are looking to set up a dibbs-style container for this shared code (I think), so maybe we hold off until that's done then implement that?
Curious if @DanielPaseltiner or @m-goggins have more context; I couldn't find the symlink stuff in the tefca-viewer code, but maybe it's referred to differently in the code.
Related Issue
Fixes #1731
Additional Information
Just some lingering questions noted above. Not sure if they are blockers, but at the least, may be worth chatting about in a short call and/or parking lot.
Checklist
[ ] If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)
PULL REQUEST
Summary
This turns on the GitHub CI for TEFCA Viewer. It largely follows the structure of the ecr-viewer's config, with the exception of the cypress e2e testing.
This PR also removes the current, stale integration tests from tefca-viewer's repo to avoid an error. I think next step will need to be to determine if we want to implement cypress e2e and whether we prefer what is done that way in lieu of integration tests, since that seems to be the direction the ecr-viewer went.
Another note: I don't know if I fully understand the symlink stuff. I thought we had this shared directory so that TEFCA could use it, but if it is, it seems to be used differently to how ecr-viewer has it set up. I've left it commented out for now, but I don't know if we need to update this based on how we use it. I also know we are looking to set up a dibbs-style container for this shared code (I think), so maybe we hold off until that's done then implement that?
Curious if @DanielPaseltiner or @m-goggins have more context; I couldn't find the symlink stuff in the tefca-viewer code, but maybe it's referred to differently in the code.
Related Issue
Fixes #1731
Additional Information
Just some lingering questions noted above. Not sure if they are blockers, but at the least, may be worth chatting about in a short call and/or parking lot.
Checklist