search

CDCgov / phdi

https://cdcgov.github.io/dibbs-site/
Creative Commons Zero v1.0 Universal
28 stars 11 forks source link

Initializing replacement to shared resources container #2035

Open robertandremitchell opened 3 days ago

robertandremitchell commented 3 days ago

PULL REQUEST

Summary

VERY MUCH STILL A WIP

Sharing mostly to get a jump on work ahead of the pairing session, but this was my initial thought on building the container. This is mostly copied over from our existing JS-based containers. Because there's not an actual app, I added a very basic test-app to try to confirm that these components should be able to called in.

Will be happy to pair on this more. Considering next steps as:

  1. Finalizing this PR to confirm that this has everything needed.
  2. Adding a CI step to build this as a new container.
  3. Updating ecr-viewer (and any other services?) to use this container.
  4. Add more fully built-out unit tests, update README.
  5. Delete shared-resources.

If there are other steps or a better way to sequence, definitely happy to discuss.

Related Issue

Fixes #2019

Additional Information

Anything else the review team should know?

Checklist

robertandremitchell commented 3 days ago

A much minor-er point, but @emmastephenson and @DanielPaseltiner in particular, do we want another name for this besides dibbs-resources?