CDCgov / phdi

https://cdcgov.github.io/dibbs-site/
Creative Commons Zero v1.0 Universal
34 stars 14 forks source link

Fix breaks in Lab comments and narratives #2082

Open angelathe opened 4 months ago

angelathe commented 4 months ago

Action Requested

Lab comments and narratives currently do not maintain the original breaks/newlines, making it more difficult to read. As a user, I want to see the breaks that separate the text so that it’s easier to read.

Acceptance Criteria

GIVEN an eCR with lab info WHEN a lab result has a narrative and/or comment(s) THEN the viewer should keep the original spacing/new lines of the text.

What should be changed:

Testing

Test fixtures, snapshot, and other unit tests may need to be updated.

Designs

Figma designs

NOTE From Sarah: Even if the original has too many breaks between text, we would rather have all the breaks than none at all.

Background & Context

Examples below from 61f13d32-b25c-4fb6-998b-73de2dbf87f2 (Link to eCR viewer)

Example: Lab Comments (see: Hepatitis C IgG w/Rfx PCR)

image.png

Example: Lab Narrative (see: FISH ALL PnL)

image.png
gordonfarrell commented 4 months ago

Look at Nick's recent PR #2049 for Labs for a similar situation

sarahtress commented 3 months ago

opening this ticket up again because it still seems to not be showing line breaks