CDCgov / phdi

https://cdcgov.github.io/dibbs-site/
Creative Commons Zero v1.0 Universal
32 stars 14 forks source link

eCR Library Table Formatting | Non-Integrated eCR Viewer #2152

Closed gordonfarrell closed 1 month ago

gordonfarrell commented 1 month ago

User Story

As somebody viewing the eCR Library table, I want to see a user-friendly table, so that I can easily understand and scan through the eCRs my public health department has received

Acceptance Criteria

The table must match the Figma designs linked below, specifically:

Scenarios

Use the scenarios below to help in testing the ticket before/during/after design review to ensure it meets the criteria above

Scenario 1:

Scenario 2:

Scenario 3:

Design Notes

Link to Figma design in Dev mode Link to Figma prototype

Screenshots below should not be used for working on this ticket - always refer to Figma design for most up-to-date designs:

Focus of this ticket is just on styling for the highlighted red area. not worrying about pagination components, header, page title, or search at this time (and checking the actual contents of the table is a different ticket):

Screenshot 2024-07-18 at 10.02.08 AM.png
angelathe commented 1 month ago

Alternating grey and white rows, making sure colors in table match Figma designs

@sarahtress For the alternating grey/white rows, the USWDS component starts with a grey row and then alternates to white -- but in the Figma designs, first row is white and then alternates to grey. Do you have a strong preference for this?

sarahtress commented 1 month ago

Alternating grey and white rows, making sure colors in table match Figma designs

@sarahtress For the alternating grey/white rows, the USWDS component starts with a grey row and then alternates to white -- but in the Figma designs, first row is white and then alternates to grey. Do you have a strong preference for this?

if it's not too much work to make it white first, I prefer it, but if it's gonna be a total pain, then it's not that important

angelathe commented 1 month ago

FYI, I'm closing this issue because the designs have changed. Changes made in the related PR will be carried over into https://github.com/CDCgov/phdi/issues/2244.