robertandremitchell commented 2 months ago

PULL REQUEST

Summary

This adds a select-query component to begin to bring the design of the /query workflow in line with Figma: https://www.figma.com/design/YU5hAHY1Eg7J6gtNbBxm7d/DIBBs-Site-Experiences?node-id=2923-11220&node-type=canvas&m=dev

The select-query logic can be reached by a very, very, very inelegant button at the bottom of the /query SearchForm page Go to Select Query.

A few notes: Submit and Back to Select patient does not seem to work at the moment. We will need to refactor this to connect/work with the patient-results and results. I set up the select-query to get to each page, but we will need to rework. We will similarly need to rework the customize-query button to be able to go back to this new page.

The inelegant button will be removed before being merged.

Related Issue

Fixes #2606

Acceptance Criteria

Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)

Additional Information

Anything else the review team should know?

Checklist

[ ] If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

fzhao99 commented 2 months ago

calling out that we made a ticket for the "connect the pipes together" work here: https://app.zenhub.com/workspaces/skylight-dibbs-viper-6480ba23b5a07644e0e46d23/issues/gh/cdcgov/phdi/2663

robertandremitchell commented 1 month ago

@mikang , quick question: What set of copy should we use in the explanatory text below Step 3: Select a query? The Figma has two on the different pages here: https://www.figma.com/design/YU5hAHY1Eg7J6gtNbBxm7d/DIBBs-Site-Experiences?node-id=3576-42496&node-type=frame&m=dev

mikang commented 1 month ago

@robertandremitchell we are going to do a full copy sweep / update with Matt later, so any text works for now! Let's use the first one: We will request all data related to your selected patient and query. By only showing relevant data for your query, we decrease the burden on our systems and protect patient privacy. If you would like to customize the query response, click on the “customize query” button.

robertandremitchell commented 1 month ago

@robertandremitchell we are going to do a full copy sweep / update with Matt later, so any text works for now! Let's use the first one: We will request all data related to your selected patient and query. By only showing relevant data for your query, we decrease the burden on our systems and protect patient privacy. If you would like to customize the query response, click on the “customize query” button.

makes sense, thanks! that copy is now in place on the page. Should be ready for re-review; I've added screenshots to the PR.