CDCgov / phdi

https://cdcgov.github.io/dibbs-site/
Creative Commons Zero v1.0 Universal
35 stars 14 forks source link

Philly Message Parser Config Returns Nulls for RR Data #2692

Open JNygaard-Skylight opened 1 month ago

JNygaard-Skylight commented 1 month ago

Description

When using the philly_ecr.json config for the message-parser the RR portion as described by the chunk of the config JSON below returns [ { uuid: null, condition: null, rule_summaries: null } ]:

"rr": {
    "fhir_path": "Bundle.entry.resource.where(meta.profile = 'http://hl7.org/fhir/us/ecr/StructureDefinition/rr-reportability-information-observation')",
    "data_type": "array",
    "nullable": true,
    "secondary_schema": {
      "uuid": {
        "fhir_path": "(meta.profile = 'http://hl7.org/fhir/us/ecr/StructureDefinition/rr-reportability-information-observation').id",
        "data_type": "string",
        "nullable": true,
        "metadata": {
          "category": "RR Reportability Information"
        }
      },
      "condition": {
        "fhir_path": "(meta.profile = 'http://hl7.org/fhir/us/ecr/StructureDefinition/rr-reportability-information-observation').valueCodeableConcept.coding.display",
        "data_type": "string",
        "nullable": true,
        "metadata": {
          "category": "RR Reportability Information"
        }
      },
      "rule_summaries": {
        "fhir_path": "(meta.profile = 'http://hl7.org/fhir/us/ecr/StructureDefinition/rr-reportability-information-observation').extension.where(url = 'http://hl7.org/fhir/us/ecr/StructureDefinition/us-ph-determination-of-reportability-rule-extension').valueString",
        "data_type": "string",
        "nullable": true,
        "metadata": {
          "category": "RR Reportability Information"
        }
      }
    }
  },

Steps to reproduce

Run the message-parser, with the philly_ecr.json config with a FHIR bundle that has RR.

Expected Result

The RR UUID, conditions, and summaries should be a non-null value.

Actual result

[ { uuid: null, condition: null, rule_summaries: null } ]

Priority

Provide an estimate for level of impact the bug has today by placing an X in the applicable bracket

Priority

Notes

Lina has suggested changing the line: "fhir_path": "(meta.profile = 'http://hl7.org/fhir/us/ecr/StructureDefinition/rr-reportability-information-observation').id", to "fhir_path": "Resource.id",, and similarly for 351, 360, but I have not had time to check this.

emmastephenson commented 4 weeks ago

Related to #2694 - that may fix this issue for Philly, but we should check after completion.