Closed lina-roth closed 1 week ago
Approved, looks great
Code looks good, but could you write some unit tests for this? (evaluatePatientName
and evaluatePatientAddress
)
Also, I'm not sure if this is related, but for this eCR, the second address just displays "USA".
@angelathe - added some tests.
For ecr 1.2.840.114350.1.13.478.3.7.8.688883.230886
This is what is in the eICR, I can make a ticket to discuss if we would like to determine what is a valid or invalid address
<streetAddressLine nullFlavor="UNK"/>
<city nullFlavor="UNK"/>
<state nullFlavor="UNK"/>
<postalCode nullFlavor="UNK"/>
<country>USA</country>
<useablePeriod xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:type="IVL_TS">
<low value="20171117"/>
<high value="20171121"/>
</useablePeriod>
</addr>
PULL REQUEST
Example of 1 name or 1 address
Example of multi name or multi address
Summary
Related Issue
Fixes #2740
Acceptance Criteria
Checklist