CDCgov / phdi

https://cdcgov.github.io/dibbs-site/
Creative Commons Zero v1.0 Universal
35 stars 14 forks source link

add mutiple names and addresses #2911

Closed lina-roth closed 1 week ago

lina-roth commented 1 week ago

PULL REQUEST

Example of 1 name or 1 address

Screen Shot 2024-11-15 at 4 04 14 PM Screen Shot 2024-11-15 at 4 04 23 PM

Example of multi name or multi address

Screen Shot 2024-11-15 at 4 04 40 PM Screen Shot 2024-11-15 at 4 04 52 PM

Summary

Related Issue

Fixes #2740

Acceptance Criteria

Checklist

ashton-skylight commented 1 week ago

Approved, looks great

angelathe commented 1 week ago

Code looks good, but could you write some unit tests for this? (evaluatePatientName and evaluatePatientAddress)

Also, I'm not sure if this is related, but for this eCR, the second address just displays "USA".

lina-roth commented 1 week ago

@angelathe - added some tests.

For ecr 1.2.840.114350.1.13.478.3.7.8.688883.230886

This is what is in the eICR, I can make a ticket to discuss if we would like to determine what is a valid or invalid address

                <streetAddressLine nullFlavor="UNK"/>
                <city nullFlavor="UNK"/>
                <state nullFlavor="UNK"/>
                <postalCode nullFlavor="UNK"/>
                <country>USA</country>
                <useablePeriod xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:type="IVL_TS">
                    <low value="20171117"/>
                    <high value="20171121"/>
                </useablePeriod>
            </addr>

2914 created