CDCgov / prime-central

Apache License 2.0
9 stars 2 forks source link

Fix Time on Results Page #147

Closed aliciabeckett-gov closed 3 years ago

aliciabeckett-gov commented 3 years ago

As a person submitting tests, I want to see the time that a test was submitted, so I can easily confirm the test I submitted is showing up in the results page or find a specific past test result.

Update Results page to do a better job of showing time with the results.

In priority order:

dmethvin-gov commented 3 years ago

@aliciabeckett-gov This will require changes on both frontend and backend because currently the database only stores the date and not the time. We'll need to change the way the date is stored, which will break existing data most likely, and then I can parse and reformat to local time in the frontend.

Another question is exactly when that date and time should be. Right now it is the time the backend received the information from the frontend. It is not the date the time the test was administered or the time the result was read.

dmethvin-gov commented 3 years ago

PR in https://github.com/CDCgov/prime-data-input-client/pull/210

aliciabeckett-gov commented 3 years ago

Missed the question (sorry about that) but just looked at the results page and the timezone looks great!

dmethvin-gov commented 3 years ago

@aliciabeckett-gov Great! Yeah, the question about what this time represents would need to be addressed elsewhere, but for now you know it's the time when they submit the result to the backend. If people are batching these in their workflow and entering them much later it might not be close to the time they tested.

aliciabeckett-gov commented 3 years ago

That's perfect!