CDCgov / prime-central

Apache License 2.0
9 stars 2 forks source link

Search for an existing patient and add them to the test queue #53

Closed aliciabeckett-gov closed 4 years ago

aliciabeckett-gov commented 4 years ago

As someone checking in patients for a test, I want to add patients to the test queue as they arrive, so that they can be tested and their result can be recorded.

Acceptance Criteria

As of Nov 2, 2020:

UI here: https://heather574841.invisionapp.com/console/PDI-10-14-2020-HM-ckg9uf825007z01yg6dgr93w1/ckg9uf8v4006w010i942z0wuo/play

sharmaneil commented 4 years ago

@hmyers-cms should patients be added to the top of the queue? I believe I asked this before in an invision comment, but can't find the response from the link in the comment.

sharmaneil commented 4 years ago

I think this ticket is too big. Requiring the AOE questionaire means #56 becomes a blocker since the AOE form would have to exist for this ticket to be complete.

Furthermore, this ticket already requires:

Arguably, many of the above items should be separate issues too

sharmaneil commented 4 years ago

This raises the question about story scope. There doesn't need to be a 1:1 mapping of pull request to stories, but this story could be a full sprint itself.

pete-gov commented 4 years ago

What about creating an Epic label and maybe a separate swim lane for epics, then linking tasks to them via # mentions? Not as clear as Jira et al, but it's a way to increase some organization in the manner that many of us are used to while sticking with github.

switzersc-usds commented 4 years ago

Agreed! This is more of a full workflow than a discrete user story (maybe we're all using the term a bit differently). I agree an Epic label could work to keep track of stories linked by workflow.

aliciabeckett-gov commented 4 years ago

@sharmaneil makes sense to move the AOE questions to a separate ticket. Do you want to break up more of the story? I saw you already started on it so don't want to disrupt your workflow on the ticket.

hmyers-cms commented 4 years ago

@sharmaneil to answer your question, I think newly added people should go to the bottom of the queue so that you can work through the queue chronologically from top to bottom

sharmaneil commented 4 years ago

I removed the AOE work from this story. Now, aside from a fair amount of style work and a few small missing things from each patient in the queue, this behemoth issue is approaching completion.

It could use QA: https://prime-data-input-staging.app.cloud.gov/ You will have to clear browser storage. There are two ways:

  1. Click the red button at the bottom of the page and then refresh the page
  2. Clear it manually:
    • right click
    • "inspect"
    • Go to the "Application" tab
    • Click "Clear storage" on the left panel
    • Click "Clear Site data" in the main content
    • refresh the page

You can search for "Edward", "James", or "John"

pete-gov commented 4 years ago

Created #101 to track dispatching this data when backend is built. Closing.