search

CDCgov / prime-devops

Apache License 2.0
4 stars 2 forks source link

Investigate Sonar improvments #114

Closed jeremy-page closed 4 months ago

jeremy-page commented 4 months ago

To try and split out FE and BE reporting by specifying we are a "monorepo". https://docs.sonarsource.com/sonarcloud/advanced-setup/monorepo-support/#convert-a-standard-project

Talk to Joseph Anderson if you have questions around why/what it should look like.

dkrylovsb commented 4 months ago

I created a test branch and made an isolated commit that affected back-end only. The commit produced a finding in Sonar as intented: image

I then made a second commit isolated to the front-end code, which produced another finding. The findings did not overwrite -- they accumulated in Sonar: image

I think this is a non-issue because as @snesm mentioned "the SonarCloud functionality has been moved to a separate workflow so that it no longer directly impacts the frontend and backend builds".

snesm commented 4 months ago

As @dkrylovsb noted and tested, the current functionality is not failing.

IIRC the overwrite only occurs on merge to master, and will not occur with the current workflow configuration. Unfortunately, changes to the workflow to show the overwrite/delete issue on merge to master will damage long term statistics used by SonarCloud.