CDCgov / prime-reportstream

ReportStream is a public intermediary tool for delivery of data between different parts of the healthcare ecosystem.
https://reportstream.cdc.gov
Creative Commons Zero v1.0 Universal
69 stars 39 forks source link

Investigate why unlinted work is being checked in #11163

Open jeremy-page opened 1 year ago

jeremy-page commented 1 year ago

ktlint should be running as part of our pre-commit hooks but we've seen at least two instances where unlinted code has been pushed to GitHub.

Done criteria for this issue is to know why the linting is not occuring and make sure it's required to push code (or maybe before merging to master).

mkalish commented 1 year ago

@jeremy-page FYI there are a few different ways that the pre-commit hooks don't get run

Now that linting gets run as part of the CI build I do think they should never make it to master