Open jeremy-page opened 1 year ago
@jeremy-page FYI there are a few different ways that the pre-commit hooks don't get run
--no-verify
is used; there is a legitimate use case for this when code needs to be shared but is not passing linting yet (i.e. a prototype)Now that linting gets run as part of the CI build I do think they should never make it to master
ktlint should be running as part of our pre-commit hooks but we've seen at least two instances where unlinted code has been pushed to GitHub.
Done criteria for this issue is to know why the linting is not occuring and make sure it's required to push code (or maybe before merging to master).