Clean up HL7v2 -> FHIR -> HL7v2 mappings

jack-h-wang commented 5 months ago

User Story

As a RS engineer, I want to ensure all FHIR mappings are completed so that they are maintainable and concise.

Description/Use Case

With #14249 complete there are HL7v2 <-> FHIR mappings that we should now be able to complete that were not covered by the message classes we previously utilized. This is to go back and add any mappings relevant to RS that might be missing and clean up any work that might not be consistent with other work.

Risks/Impacts/Considerations

Dev Notes

This ticket is to look into the following specifically:

Complete mappings for PRT
Complete mapping for OBX-33

Acceptance Criteria

[x] PRT and OBX Updated

Andrey-Glazkv commented 5 months ago

Hey team! Please add your planning poker estimate with Zenhub @adegolier @arnejduranovic @brick-green @david-navapbc @jack-h-wang @jalbinson @JFisk42 @mkalish @thetaurean

jack-h-wang commented 2 weeks ago

PR #16236 is currently under review. Obstacles encountered during this work:

15511 was not initially identified as a blocker. Some work was started but will need the blocker resolved to complete (see #16479)
These mappings depend on other mappings that we had not previously identified, increasing the scope of work.
Issues with existing mappings were found and corrected during testing.
Some of the mappings implemented caused an unintended change of behavior with regard to FHIR input from SimpleReport. We will need to coordinate with them to ensure the new mappings are consistent with those used by SR. In the meantime, the completed mappings focus on retaining all inputs from HL7.

Additionally, I was out sick for several days and was on deployment duty during the previous sprint, with DevOps shadowing. This shadowing has also persisted into the current sprint with the issues caused by the base branch being switched to main.

CDCgov / prime-reportstream