search

CDCgov / prime-reportstream

ReportStream is a public intermediary tool for delivery of data between different parts of the healthcare ecosystem.
https://reportstream.cdc.gov
Creative Commons Zero v1.0 Universal
72 stars 40 forks source link

[BUG] Daily data filename is incorrect #15644

Open victor-chaparro opened 3 months ago

victor-chaparro commented 3 months ago

Describe the bug

When navigating to the daily data page the filename shows the same timestamp for all results and changes every time you refresh.

Another related issue is that the external filename is not being displayed for receivers on the ELIMS topic. It shows the RS generated filename.

Impact on ReportStream

Support and engagement teams are not able to find filenames for receivers when support issues come up. Unable to tell receiver to check for specific filenames when they have files ready to validate.

ELIMS is not able to search for files received in daily data.

Steps to reproduce

Reproduce timestamp bug

Login as an admin to ReportStream. Use any organization that has a receiver - ca-dph Navigate to Daily data and notice how all filename have the same timestamp.

Reproduce ELIMS bug

Login as an admin to ReportStream's staging environment. Use ELIMS as an organization Navigate to Submission history capture the filenames displayed there Navigate to Daily data and notice how all filenames show the RS generated filename and not the external filename.

Expected behavior

etanb commented 2 months ago

FYI: We're skipping an e2e test in CI until this ticket is fixed: #15730

etanb commented 1 month ago

@chris-kuryak @victor-chaparro we need to prioritize this ticket since it's still broken and blocking complete e2e coverage. We must still skip the returns match for Filename test in our e2e suite.

chris-kuryak commented 1 month ago

@etanb Platform team is currently working on this as a two-part fix:

  1. 16191 - Updating all reports to go through the Send step (currently in review)

  2. This ticket - Update the Daily Data API to return the correct filename

I have added #16191 as a dependency to this ticket. But we will need to check in with Platform at the end of the sprint to see what there timeline is on updating the API. @adegolier is currently working on it from the Platform team.

However, making this change has implications to the Daily Data page and what data is shown, so I would not expect it to be fixed until November.

chris-kuryak commented 1 week ago

@adegolier Can we get a status update on this work?