CDCgov / prime-reportstream

ReportStream is a public intermediary tool for delivery of data between different parts of the healthcare ecosystem.
https://reportstream.cdc.gov
Creative Commons Zero v1.0 Universal
73 stars 40 forks source link

[BUG] Check function not working for REST Transport #15794

Closed victor-chaparro closed 1 month ago

victor-chaparro commented 2 months ago

Describe the bug

The REST transport authentication logic has been updated and did not get updated for the Check Function. The Check function runs every two hours and is throwing exceptions when checking the REST transport for CADPH

Dev Notes

We need to update the logic for testRest under CheckFuntion.kt. We should leverage the logic the is inside REST Transport to avoid duplicating logic in two places and preventing issues like this from happening.

Steps to reproduce

Navigate to the Receiver Status Dashboard and notice how the check is failing for CADPH every time.

Expected behavior

oslynn commented 2 months ago

In RESTTransport.kt: getOAuthToken(), it doesn't have UserJksCredential support.

oslynn commented 2 months ago

CA-DPH uses the JKS credential none-auth for communication. For REST endpoint doesn't have to authenticate (e.g. endpoint that use CERT or JKS install in client's engine), we will need way to check the endpoint. I am researching for what is the best way.

oslynn commented 1 month ago

Done.