CDCgov / prime-reportstream

ReportStream is a public intermediary tool for delivery of data between different parts of the healthcare ecosystem.
https://reportstream.cdc.gov
Creative Commons Zero v1.0 Universal
71 stars 39 forks source link

Add new mapping yaml validation #16081

Open JFisk42 opened 3 days ago

JFisk42 commented 3 days ago

User Story

As a ReportStream developer I want to be notified when conditional operators are formatted incorrectly, so that I am immediately aware of my mistake.

Description/Use Case

For the HL7 -> FHIR mappings, if NOT NULL is provided for a conditional field instead of NOT_NULL there is no syntax error that appears. Would be a nice to have

Risks/Impacts/Considerations

With the mapping yaml validations, it would be nice to add more formatting checks as we come across them. Probably this task is best left until there are several to tackle all at once.

Dev Notes

One potential weird edge case here is that NULL by itself is a valid condition keyword but NOT NULL isn't. Because there is a space between NOT and NULL, the effort to work around that may not be worth the syntax highlighting.

Acceptance Criteria

MichaelEsuruoso commented 4 hours ago

Hey team! Please add your planning poker estimate with Zenhub @adegolier @arnejduranovic @david-navapbc @jack-h-wang @JFisk42 @kant777 @mkalish @thetaurean