search

CDCgov / prime-reportstream

ReportStream is a public intermediary tool for delivery of data between different parts of the healthcare ecosystem.
https://reportstream.cdc.gov
Creative Commons Zero v1.0 Universal
72 stars 40 forks source link

[bug] Manual entries to poison queue are not base64 encoded #16609

Closed arnejduranovic closed 5 days ago

arnejduranovic commented 5 days ago

Describe the bug

https://github.com/CDCgov/prime-reportstream/pull/16258/files does not encode messages to base64 before sending to the poison queue, which results in the poison queue messages not being able to be processed by the Azure framework when moved back to a normal queue.

Impact on ReportStream

Engagement team cannot re-queue poison queue messages that were created by the new code.

Steps to reproduce

Steps to reproduce the behavior:

We can reproduce locally:

  1. Set up a sender-receiver pair
  2. Update the schema of the receiver to be an invalid value
  3. Send a message
  4. Verify a message appears in translate poison queue
  5. Try to move the poison queue message to the normal queue and see that the breakpoint in FHIRFunctions.translate never gets hit and message remains in poison queue

Expected behavior

poison queue message should get reprocessed when moved to normal queue