CDCgov / prime-reportstream

ReportStream is a public intermediary tool for delivery of data between different parts of the healthcare ecosystem.
https://reportstream.cdc.gov
Creative Commons Zero v1.0 Universal
70 stars 39 forks source link

Add ability to suppress extraneous column warnings #2022

Open jimduff-usds opened 3 years ago

jimduff-usds commented 3 years ago

See the zillion "ignore" fields in this schema: prime-router/metadata/schemas/Experity/experity-covid-19.schema

(From this PR: https://github.com/CDCgov/prime-reportstream/pull/2004/files)

There's got to be a better way to ignore extraneous fields coming from a sender. This story is to find that better way, and implement it. Maybe a flag per-sender, or per-POST-submission (seems like the latter would be better?)

jimduff-usds commented 2 years ago

I'd like to re-evaluate how bad this problem is after #1285 is done. Maybe that will be good enough to ameliorate this situation. If not, then we'll move ahead with attacking this.

jimduff-usds commented 2 years ago

Lowering the priority of this for now. #4417 will consolidate messages, which will help with this. Also, I believe the CSV Uploader tool will initially just be ignoring warnings. (!)

A first step would be to eval how many warnings we are sending back to CSV Uploader users. How bad is it?