CDCgov / prime-reportstream

ReportStream is a public intermediary tool for delivery of data between different parts of the healthcare ecosystem.
https://reportstream.cdc.gov
Creative Commons Zero v1.0 Universal
72 stars 40 forks source link

React transition: common link styling #2230

Closed drew-usds closed 1 year ago

drew-usds commented 3 years ago

Describe the bug Links are showing in a few different ways, would be helpful to have a common class applied to each and have some different options for external links as well.

Impact Please describe the impact this bug is causing to your program or organization.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Screenshots If applicable, add screenshots to help explain your problem.

Logs If applicable, please attach logs to help describe your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

drew-usds commented 3 years ago

Tagging you on this one @TomNUSDS since you flagged this in the QA meeting!

TomNUSDS commented 3 years ago

USWDS has <Link> component used in a few places. There's also an attribute on the component variant="external" that appends an open-in-new-window icon. However, it does not add target="_blank" rel="noopener".

There is a Custom Link USWDS component that might work. See discussion around customizing links

@drew-usds Should our custom external links have the graphics? image

HeatherRienks commented 1 year ago

Closing for now. Old issue. @chris-kuryak to link to table component tix