search

CDCgov / prime-reportstream

ReportStream is a public intermediary tool for delivery of data between different parts of the healthcare ecosystem.
https://reportstream.cdc.gov
Creative Commons Zero v1.0 Universal
70 stars 39 forks source link

[Bug] Admin Settings: Edit/Clone/Delete buttons are clipped on smaller displays #4351

Open sethdarragile6 opened 2 years ago

sethdarragile6 commented 2 years ago

Describe the bug When using the Org Edit Page on a smaller display, the rightmost buttons for a particular setting can rendered unreadable and/or inaccessible.

Ex. org "strac" on staging image.png

Impact Limited or impaired functionality.

To Reproduce

  1. Login as admin, go to Admin->Organization Settings
  2. Choose an organization from the list
  3. View page on a smaller device, or resize window on a larger display

Expected behavior Buttons should be readable and accessible on a smaller display

bgantick commented 2 years ago

@rachelhanster @RakshindaAslam After investigating, we decided to de-prioritize this at least until #5304 (new ticket to adapt to recent changes to the response from the settings API) is resolved. In its current form, this isn't an issue on smaller viewports.

hannasage commented 1 year ago

@fmccaf1 @drew-usds Great opportunity when revamping Admin UIs is considering mobile-friendly layouts, or messaging for mobile users that we don't support mobile UIs if that is what we desire

HeatherRienks commented 1 year ago

@brick-green -does this bug still exist and is this still an issue?

cc: @brandonnava @chris-kuryak

brick-green commented 1 year ago

I don't know if this bug exists. I don't use the system on a mobile device. Is responsive layout something RS needs to consider?

HeatherRienks commented 1 year ago

Ok, thanks for the feedback @brick-green Tagging our additional Designers for input/direction!

cc: @lizzieamanning @jillian-hammer @fmccaf1

chris-kuryak commented 1 year ago

Setting to Low Priority until we have confirmation that this bug (a) still exists and (b) is an issue for any user (meaning, to Brick's point, does any user use a smaller display)

hannasage commented 1 year ago

@chris-kuryak Chiming in from the beyond: we DO log device types of some kind naturally through W3C telemetry data in Azure logs. We could make device types (i.e. mobile vs desktop vs smart fridge) an insight graph if you wanna ticket that for later refinement/action. 😀

chris-kuryak commented 1 year ago

Thanks, @kevinhaube. Good to know as we progress into expanding Web Analytics features/views .

chris-kuryak commented 1 year ago

@jillian-hammer @audreykwr Do you have a preferred solution from a design perspective as to how tables should react in this situation?