Fetch Refactor: Final cleanup of remaining rest-hooks

[doug-s-nava]

Problem statement

As a report stream developer I want to replace all instances of usage of rest-hooks with react query based hooks. Though most of the work has already been completed, this final ticket is to: 1) Discover any remaining dependencies/occurrences of rest-hooks in the code base 2) Fix those dependencies/occurrences over to react-query 3) Remove rest-hooks as a dependency of the project

This will allow us to completely move over to react-query with no more dependency on rest-hooks.

Notes

Remove all remaining traces of rest-hooks

• testing
• packages
• helper files

Check anything else we may have missed

Acceptance criteria

• [ ] Discover any remaining dependencies/occurrences of rest-hooks in the code base
• [ ] Fix those dependencies/occurrences and replace with necessary react-query code
• [ ] Remove rest-hooks as a dependency of the project
• [ ] Check that when the rest-hooks package is removed from the app, everything still works as normal

To do

Check:

• [ ] testing
• [ ] packages
• [ ] helper files
• [ ] components
• [ ] Check anything else we may have missed

[chris-kuryak]

@jpandersen87 @stephenkao Is this issue still valid as written? It seems a little old and sparse, so checking to see if it is ready for team refinement this week.

[doug-s-nava]

did you all already transition all of the rest hooks based api calls to react query?

[stephenkao]

I think @jpandersen87 can speak more to this. The work to remove the rest-hooks package is still valid, but it looks like Joseph's draft branch is removing a lot of references to the package exports from our code -- so depending on what comes out of that, this ticket may be redundant. Maybe let's slap a needs-info label on it and close if it turns out to be covered? What do you think @jpandersen87?

[jpandersen87]

This is more like a parent ticket to the ones that I have been doing to update fetching hooks to react-query.

[doug-s-nava]

my intention with this ticket was as a final cleanup - once the application is fully functioning with react query, all of the remaining cruft around rest hooks (testing, helpers, types, etc.) can be removed. I evidently didn't take the time to catalog where all of that stuff was, though

[chris-kuryak]

@jpandersen87 So is your current work covering everything in this ticket and the concerns mentioned by Doug above? I am just trying to figure out if we need this ticket anymore, or if we need to rewrite it.

[chris-kuryak]

This is blocked by all of the other hook replacement tickets. Search "hooks" with tech-debt label to see them.

[KeithNava]

@KeithNava followup and possibly refactor as a cleanup ticket