search

CDCgov / prime-simplereport

SimpleReport is a fast, free, and easy way for COVID-19 testing facilities to report results to public health departments.
https://simplereport.gov
Creative Commons Zero v1.0 Universal
58 stars 54 forks source link

Extract text from "print test result" view into translation configuration files #2148

Closed nathancrtr closed 3 years ago

nathancrtr commented 3 years ago

The Prepare patient test results for Translation (#1936) ticket specified that all text in the patient test result workflow be extracted into translation configuration files. One file was missed in that effort: TestResultPrintModal.tsx. This file should be i18nized as well.

Acceptance Criteria

aliciabeckett-gov commented 3 years ago

Have not internationalized this component yet.

aliciabeckett-gov commented 3 years ago

@kenieh - need the design for how to switch the printed test result into Spanish

kenieh commented 3 years ago

@aliciabeckett-gov @nathancrtr Here's the design: https://www.figma.com/file/NPSPM5SBzQ7Ra3mmr9M9cB/SimpleReport-Public-Site?node-id=3434%3A11203

Whenever this gets code on the frontend, would love to do quick pairing with the engineer to double-check the button styling. I made some minor visual adjustments to the translation button design by Heather. Also happy to pair pre-emptively with the eng to walk through the button styling if helpful

nathancrtr commented 3 years ago

A few more translations are required for this work:

@Rebecca-LM hopefully this isn't too much to ask you to do out-of-band, but if so, please let me know and I'll work with @aliciabeckett-gov to get official translations!

Rebecca-LM commented 3 years ago

@nathancrtr Please see below. Note that I included the link to the Spanish version of the info, vs. the original English language link you had. I just wanted to flag this for myself and so we can all remember to look for Spanish versions for any links we're including, when possible!

aliciabeckett-gov commented 3 years ago

@nathancrtr I have the strings below, but are those the ones in TestResultPrintModal.tsx or is that a different set of strings?