CDCgov / prime-simplereport

SimpleReport is a fast, free, and easy way for COVID-19 testing facilities to report results to public health departments.

https://simplereport.gov

Creative Commons Zero v1.0 Universal

57 stars 55 forks source link

Add LOINC description fields on add/edit device page #7795

Closed bobbywells52 closed 3 months ago

bobbywells52 commented 3 months ago

FRONTEND PULL REQUEST

Related Issue

Solves #7179

Changes Proposed

Update diseaseForm and diseaseInformation components so that they both read from and write to the testPerformedLoincLongName and testOrderedLoincLongName attributes as defined in our Device Type Disease Table.
Update the getDeviceTypeList qraphGL querry to return testPerformedLoincLongName and testOrderedLoincLongName.
Add input options to the edit device page for the user to update the loinc long names with.

Testing

This code is live on dev2. To test, go to the add/edit device page and verify that the fields for both of the long names are there. Update the values with new values and verify that they persist on refresh and/or in metabase.

Screenshots

Worked with @kenieh and settled on a red "Delete disease" button rather than the red trash can in its own row by itself

Screenshot 2024-06-24 at 17 18 48

emyl3 commented 3 months ago

⚠️ Please don't review yet as I'm cleaning up the styles as per Bobby's request! :)

emyl3 commented 3 months ago

@mehansen @mpbrown @fzhao99 -- this is now ready for review!

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

emyl3 commented 3 months ago

Will merge this tomorrow!