CDCgov / prime-simplereport

SimpleReport is a fast, free, and easy way for COVID-19 testing facilities to report results to public health departments.
https://simplereport.gov
Creative Commons Zero v1.0 Universal
56 stars 55 forks source link

Resend 238 test events with corrected AOE responses #7929

Open mpbrown opened 2 months ago

mpbrown commented 2 months ago

Description

We had a recent bug ticket related to AOE responses not being updated on test corrections. There are cases where these corrected test events were sent to ReportStream but the submissions still had the original AOE responses.

Since 12/19/23, we've had about 2,437 test events with a "corrected" status and about 238 of these had AOE responses that do not match between the "test order" AOE data and the "test event" AOE data. See 7/11/24 eng sync

The team believes that users could already update AOE questions before the test card overhaul was added, so there might be addition test events to resend before 12/19/23. For now, we'll just focus on the 238 test events since that date.

Proposed Solution

Resend those 238 test events with the correct AOE responses.

Note - we can't simply use the existing resend mutation because we need to modify the data and test events are immutable. Do we reopen the test orders as corrections and then immediately submit them so the new test event will populate with the updated test order AOE responses?

DanielSass commented 2 months ago

Takeaways from a quick conversation with the team on this: We might need to create an entirely new endpoint to resend as a correction? Will need to touch base with report stream to ensure we're conveying these corrections correctly. The work involved in getting test event ids to resend is non-trivial. Mike said he used a quick python script to do it.