CDCgov / prime-simplereport

SimpleReport is a fast, free, and easy way for COVID-19 testing facilities to report results to public health departments.
https://simplereport.gov
Creative Commons Zero v1.0 Universal
57 stars 55 forks source link

Result view list and modal patient names don't match #8126

Open mehansen opened 2 weeks ago

mehansen commented 2 weeks ago

Description

When you view the Results page, the patient name for a result lists the patient's current name. When you click on a result and view the result details, the patient name will be the name of the patient at the time that the original test event was created. Should the patient name in the list view always match the patient name in the result details modal? For corrections, we send the updated patient name with the correction. However the result details modal will still show the patient name at the time that the original test event was created. Should the result details modal for a corrected test event have the updated patient name info?

Steps to reproduce

https://github.com/user-attachments/assets/39d6f908-297f-4be3-b0c9-527a02b2f7d0

  1. Submit a positive Covid result for a patient named Dave.
    • The result list shows the positive Covid result with the name Dave.
    • The result details modal shows the name Dave.
    • The FHIR bundle generated contains the name Dave.
  2. Change the patient's name to David.
    • The result list view shows the positive Covid result with the name David.
    • The results detail modal shows the name Dave.
    • No message sent to RS when a patient's name is changed.
  3. Submit a correction for the positive Covid result, changing it to negative.
    • The result list view shows the now negative Covid result with the name David.
    • The results detail modal shows the updated negative Covid result with the name Dave.
    • The FHIR bundle generated contains the name David.

Expected behavior

Names in list view and results detail modal should match?

Details modal after the correction should show the name David since that's what was sent to RS. In the backend, the test event for the correction should have David in the patient_data.

Additional context

This doesn't seem like a problem that impacts users often but I'm recording what I know about the behavior in this ticket so we have it documented.