emyl3 commented 1 week ago

FRONTEND PULL REQUEST

Related Issue

Our frontend build job was initially passing following the Node 23 upgrade. Recently, the same job began to fail.

@mehansen found that version 23.2.x of NodeJS released on November 11, 2024 is breaking our frontend builds

Changes Proposed

Specify the minor version of NodeJs to avoid this regression

Additional Information

Previous comment

⚠️ I didn't change the image in our frontend Dockerfile because it looks like that image uses node 23.1.0. Let me know if you prefer I choose a different image though 🤔

Updated to a Docker image with node 23.1.0 set

See other reported issues:

Internal convo here

Testing

All checks (maybe minus Trivy 😅 -- unrelated to this) should pass
deployed on dev6

Screenshots / Demos

N/A

mehansen commented 1 week ago

do we know how often the Docker images are updated and how that impacts us? I assume someone would update it to use 23.2 soon enough. if that happens will our frontend start failing to build?

tagging @shanice-skylight in case she has more insight

emyl3 commented 1 week ago

do we know how often the Docker images are updated and how that impacts us? I assume someone would update it to use 23.2 soon enough. if that happens will our frontend start failing to build?

tagging @shanice-skylight in case she has more insight

During pairing @mehansen found this image that sets it to node 23.1 so I'll update with this one for now!