search

CDCgov / pyrenew-hew

Models and infrastructure for forecasting COVID-19 and Flu hospitalizations using wastewater data with PyRenew
Apache License 2.0
5 stars 0 forks source link

Better location filtering / data availability checks when fitting models #100

Open dylanhmorris opened 3 weeks ago

dylanhmorris commented 3 weeks ago

So we don't end up with phantom directories representing areas without available data.

damonbayer commented 5 days ago

@dylanhmorris I'm not sure if this was resolved or if we remember what the problem was. Can you add detail to the issue or close it?

dylanhmorris commented 5 days ago

I think we had blank directories for places like AS that aren't in the NSSP

damonbayer commented 5 days ago

Do we know if that is still a problem? If we aren't sure, we can close this unless it comes up again.

dylanhmorris commented 5 days ago

I believe this will still run even if the retrieved data table is length 0. Fix for this would just be to add a check and error if no location-specific data

https://github.com/CDCgov/pyrenew-hew/blob/4c743a9feff9cc1290730dd23edb7f1c88e8f787/pipelines/forecast_state.py#L195

There's currently an error if data files aren't available, but not if those files lack data for the requested location.