CDCgov / trusted-intermediary

Bringing together healthcare providers by reducing the connection burden.

Apache License 2.0

9 stars 1 forks source link

Story-1001: Azure Log Alert Set up #1102

Closed saquino0827 closed 1 week ago

saquino0827 commented 2 weeks ago

Azure HikariCP token failure log alert

Azure Log Alert Set Up for the connection pooling error.

Issue

Adding an azure log search alert for checking a fatal connection error for HikariCP getting an invalid access token into the Postgresql database.
One outstanding question I have is do we want our alert to auto mitigate or not.
- Auto mitigate would keep the alert from firing until the alert resolves itself. AKA, doesn't meet the alert condition a set number of times or for a set period of time.
- No auto mitigate would mean the alert fires every time the log statement in this PR is found, would be a bit more noisy and cost a little more.

Checklist

[ ] I have added tests to cover my changes
[ ] I have added logging where useful (with appropriate log level)
[ ] I have added JavaDocs where required
[ ] I have updated the documentation accordingly

Note: You may remove items that are not applicable

saquino0827 commented 1 week ago

Looks really good. I just have two comments on making the Terraform names more descriptive.

I appreciate the review, this has been updated.

sonarcloud[bot] commented 1 week ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud