CDCgov / trusted-intermediary

Bringing together healthcare providers by reducing the connection burden.

Apache License 2.0

11 stars 5 forks source link

CA: UCSD Results Staging EHR Filing #1229

Closed JohnNKing closed 6 days ago

JohnNKing commented 3 months ago

Story

As UCSD, so that I can review and provide patient care based on NBS findings, I need sample result messages sent by ReportStream staging to appear to clinicians in my EHR test environment.

Pre-conditions

Out of scope: Production connectivity

Acceptance Criteria

Tasks

[x] Review old ticket #1222
[x] Complete initial round trip test with CDPH and UCSD (planned for 10/3/2024)
[x] Confirm 'µ' character in a result observation was not corrupted
[x] Get confirmation from UCSD that the sample result files and displays successfully (without any manual modification)

Notes

Optional: Any reference material or thoughts we may need for later reference

basiliskus commented 3 months ago

We could add the correct encoding of µ as part of the tasks or AC

JohnNKing commented 3 months ago

We could add the correct encoding of µ as part of the tasks or AC

I know we also #1222 -- I could make resolving that bug a precondition for this story if it would help.

jorg3lopez commented 1 month ago

Update: There will be a live testing session on Wednesday, Oct 2nd. In this live session, we plan to bring up the issue with the mu character. We will ask how the value shows up in UCSD's system. This will let us know if there are any issues or if everything is working as expected.

jorg3lopez commented 4 weeks ago

Update: During the live test, we noticed that the mu character was not showing properly. We will need to do more research and see what encoding (ISO, UTF) UCSD Epic is using.

basiliskus commented 4 weeks ago

I'll do a round of testing with RS to make sure the message is sent with the mu character showing correctly

basiliskus commented 4 weeks ago

After some tests I found a couple of things. While testing locally, I found the files are correctly encoded throughout the flow. While testing in staging, I found that somewhere between RS receiving the initial HL7 message and sending the FHIR message to TI, the encoding gets garbled. So it's confirmed RS is sending the message to UCSD with the 'µ' character missing

basiliskus commented 3 weeks ago

Created a bug report in RS for the encoding issue here: https://github.com/CDCgov/prime-reportstream/issues/16196

jbiskie commented 3 weeks ago

We changed the locale to UTF-8 in the dockerfile configuration. No impact.

jbiskie commented 3 weeks ago

Removing -Dfile.encoding=UTF-8 in the JAVA_OPTS in local.settings.json breaks local deployments.

We're attempting to set this parameter for Azure deployments.

GilmoreA6 commented 3 weeks ago

Adding the "JAVA_OPTS = -Dfile.encoding=UTF-8" environment variable to the pdhdemo1 environment solved the issue. We will raise a PR to add this env variable to RS under RS issue #16196 linked above. This env variable need to be configured in the RS terraform files.

basiliskus commented 2 weeks ago

It may be worth reopening https://github.com/CDCgov/trusted-intermediary/issues/1222 because it seems there's an actual bug in Daily Data regarding the encoding of the 'µ' character, that is separate from the encoding issue currently being fixed in the deployed environments

basiliskus commented 2 weeks ago

https://github.com/CDCgov/trusted-intermediary/issues/1222 reopened

basiliskus commented 2 weeks ago

This open PR in the reportstream-sftp-ingestion repository fixes the encoding issue when sending the ORU using the SFTP service. Once the PR is merged, we need to test uploading new files to be sent in staging and checking the EHR Filing with UCSD

basiliskus commented 2 weeks ago

The encoding fix in the reportstream-sftp-ingestion service has been merged and tested in staging. We should be ready to test this issue in the staging EHR Filing

scleary1cs commented 1 week ago

Closing in favor of #1442 . Moving AC over.