basiliskus commented 3 days ago

Description

Added instructions on how to test new assertions from a new branch/PR
Added more context on how to run tests

Issue

1540

github-actions[bot] commented 3 days ago

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

**🎫 Ticket compliance analysis 🔶** **[1540](https://github.com/CDCgov/trusted-intermediary/issues/1540) - Partially compliant** Fully compliant requirements: - Instructions on how to test new assertions from a new branch/PR Not compliant requirements: - Checking for internal open/close quotes in json - Making tests fail on purpose as a gut check that they're running as expected/not passing because they're being filtered out

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review

Missing Information
The PR does not address all the requirements specified in the ticket, particularly checking for quotes in JSON and making tests fail intentionally.

github-actions[bot] commented 3 days ago