sfradkin commented 10 months ago

Story

As an HCO, so that our OML orders can be sent to our public health lab, we want RS to be able to process inbound HL7v2.5.1 OML messages.

Acceptance Criteria

[x] A properly formatted OML message is processed through RS without error.
[x] An improperly formatted OML message is returned from RS with an error.
[ ] RS sends the intermediary FHIR converted from the HL7 OML message.

Tasks

Research

n/a

Engineering

[x] Update ReportStream to be able to accept OML messages (without an HTTP error resulting) : https://github.com/CDCgov/trusted-intermediary/issues/962
[x] Determine if we can use LinuxForHealth/hl7v2-fhir-converter for OML conversion. Their readme states they only partially support it
- If we can't use LinuxForHealth, find out if there's another tool we can use
- If there's no third-party tool we can use, we need to make one
[ ] Test the behavior of TI in staging now that OML is supported
[ ] If needed, update the TI service to handle inbound FHIR resources that are unique to OML (in comparison to ORM; e.g. Patient contacts via NK1)

Definition of Done

[ ] Documentation tasks completed
- [ ] Documentation and diagrams created or updated
- [ ] Implementation guide (/ig folder)
- [ ] ADRs (/adr folder)
- [ ] Main README.md
- [ ] Other READMEs in the repo
- [ ] If applicable, update the ReportStream Setup section in README.md
- [ ] Threat model updated
- [ ] API documentation updated
[ ] Code quality tasks completed
- [ ] Code refactored for clarity and no design/technical debt
- [ ] Adhere to separation of concerns; code is not tightly coupled, especially to 3rd party dependencies
- [ ] Code is reviewed or developed by pair; 1 approval is needed but consider requiring an outside-the-pair reviewer
- [ ] Code quality checks passed
[ ] Security & Privacy tasks completed
- [ ] Security & privacy gates passed
[ ] Testing tasks completed
- [ ] Load tests passed
- [ ] Unit test coverage of our code >= 90%
[ ] Build & Deploy tasks completed
- [ ] Build process updated
- [ ] API(s) are versioned
- [ ] Feature toggles created and/or deleted. Document the feature toggle
- [ ] Source code is merged to the main branch

Research Questions

Optional: Any initial questions for research

Decisions

Optional: Any decisions we've made while working on this story

Notes

Optional: Any reference material or thoughts we may need for later reference

scleary1cs commented 9 months ago

RS already supports inbound ORM.

scleary1cs commented 8 months ago

Specify/What is the expected format for the FHIR message coming out of RS?

scleary1cs commented 8 months ago

The converter partially supports the following message types/events:

OML_O21 - Laboratory Order Repeating ORDER groups are not supported ServiceRequest resources are only created when both ORC and OBR are provided PID must be provided to avoid FHIR validation errors OBX and Observations are not yet supported