search

CDCgov / trusted-intermediary

Bringing together healthcare providers by reducing the connection burden.
Apache License 2.0
11 stars 5 forks source link

FHIR Messages Triggering Warning Messages #940

Open jorg3lopez opened 8 months ago

jorg3lopez commented 8 months ago

Bug

Warning Messages

FHIR messages coming from RS trigger warning messages that notify the user that a required value field is missing. The warnings come out of a few missing values from some, not all, Organization resources and the Practitioner resource. The warnings seem to be related to the universal-id-unknown-type and universal-id-type fields.

Impact

FHIR message might not have the proper structure.

To Reproduce

  1. Run RS, ingest initial MN ORU file to create a FHIR message
  2. Run TI and send the FHIR message to the API
  3. Check container logs to see warnings

Expected Behavior

There is still more research to be done in order to find out if the message is missing a required field from the initial HL7 translation, or if the translation to FHIR is adding additional resources without their value field.

Screenshots

Organization is missing the value field for the url of universal-id-unknown-type and universal-id-type

image.png

Practitioner is missing the value fields for the url of universal-id-unknown-type and universal-id-type

image.png

Logs

image.png
basiliskus commented 5 months ago

Need to confirm that the MN ORU sample file we're using is realistic

basiliskus commented 5 months ago

This is what the warning looks like: {"@timestamp":"2024-06-14T17:34:20.69877Z","level":"WARN","message":"Resource is missing required element: value","thread_name":"JettyServerThreadPool-18"}

saquino0827 commented 5 months ago
  1. Translate older MN example into FHIR with latest RS. a. Translated an updated MN 04 file to test the current RS.
  2. See if MN FHIR sample generates warnings a. Still receive warnings from RS
  3. If warnings exist, find out why RS is generating FHIR that generates warnings.

I translated the new CA file in RS and checked TI for warnings. There were no warnings with the new up-to-date CA file. See branch story/940/sample-files for sample files.

Attempted to use CWE to trigger warnings in the up-to-date CA file. They did not trigger warnings.

JohnNKing commented 5 months ago

Need to test with realistic AL and LA ORU messages.

brick-green commented 3 days ago

Test with current OML and ORU test messages