search

CDCgov / wastewater-informed-covid-forecasting

Wastewater-informed COVID-19 forecasting models submitted to the COVID-19 Forecast Hub
https://cdcgov.github.io/wastewater-informed-covid-forecasting/
Apache License 2.0
38 stars 6 forks source link

Unit tests for `wweval` plot functions #47

Open kaitejohnson opened 1 week ago

kaitejohnson commented 1 week ago

From @dylanhmorris : This was caught via R CMD check, but a unit test that attempted to run these plotting functions would also have caught it, likely sooner

 get_plot_hosp_data_comparison: no visible global function definition
    for ‘aes’
  get_plot_hosp_data_comparison: no visible global function definition
    for ‘xlab’
  get_plot_hosp_data_comparison: no visible global function definition
    for ‘ylab’
  get_plot_hosp_data_comparison: no visible global function definition
    for ‘ggtitle’
  get_plot_hosp_data_comparison: no visible global function definition
    for ‘theme_bw’
  get_plot_hosp_data_comparison: no visible global function definition
    for ‘scale_color_discrete’
  get_plot_hosp_data_comparison: no visible global function definition
    for ‘element_text’
  get_plot_quantile_comparison: no visible global function definition for
    ‘theme_bw’
  get_plot_quantile_comparison: no visible global function definition for
    ‘xlab’
  get_plot_quantile_comparison: no visible global function definition for
    ‘ylab’
  get_plot_quantile_comparison: no visible global function definition for
    ‘ggtitle’
  get_plot_quantile_comparison: no visible global function definition for
    ‘scale_color_discrete’
  get_plot_quantile_comparison: no visible global function definition for
    ‘element_text’
  get_plot_raw_scores: no visible global function definition for ‘aes’
  get_plot_raw_scores: no visible global function definition for
    ‘theme_bw’
  get_plot_summarized_scores: no visible global function definition for
    ‘aes’
  get_plot_summarized_scores: no visible global function definition for
    ‘theme_bw’
  get_plot_summarized_scores: no visible global function definition for
    ‘xlab’
  get_plot_summarized_scores: no visible global function definition for
    ‘ylab’
  get_plot_summarized_scores: no visible global function definition for
    ‘ggtitle’
  get_plot_summarized_scores: no visible global function definition for
    ‘scale_color_discrete’
  get_plot_summarized_scores: no visible global function definition for
    ‘element_text’
  get_plot_ww_data_comparison: no visible global function definition for
    ‘xlab’
  get_plot_ww_data_comparison: no visible global function definition for
    ‘ylab’
  get_plot_ww_data_comparison: no visible global function definition for
    ‘ggtitle’
  get_plot_ww_data_comparison: no visible global function definition for
    ‘theme_bw’
  get_plot_ww_data_comparison: no visible global function definition for
    ‘scale_color_discrete’
  get_plot_ww_data_comparison: no visible global function definition for
    ‘element_text’

The imports have been fixed but it would still be good to have more unit tests for plotting functions