CDCgov / ww-inference-model

An in-development R package and a Bayesian hierarchical model jointly fitting multiple "local" wastewater data streams and "global" case count data to produce nowcasts and forecasts of both observations
https://cdcgov.github.io/ww-inference-model/
Apache License 2.0
16 stars 2 forks source link

Various bug fixes #128

Closed kaitejohnson closed 1 month ago

kaitejohnson commented 1 month ago

This PR addresses a few semi-related issues including:

This PR branches off of #108, and shouldn't be reviewed until that is merged.

kaitejohnson commented 1 month ago

Some key fixes and suggestions. Also, is there a unit test for the internal reordering?

modifying the package ww_data so that sites are not orderd 1:n_sites but instead are in reverse order and don't start at 1. This was to try to recreate and test the bug described in #100. However, I wasn't able to reproduce this error.

A unit test to check that the reordering worked as expected? I can add to the preprocessing tests. Note in #158 we will be setting the order of the populations to descending order by site population and I added a unit test to confirm that works as expected