search

CDCgov / ww-inference-model

An in-development R package and a Bayesian hierarchical model jointly fitting multiple "local" wastewater data streams and "global" case count data to produce nowcasts and forecasts of both observations
https://cdcgov.github.io/ww-inference-model/
Apache License 2.0
17 stars 2 forks source link

Test rendering the vignette on mac and Windows in CI #206

Open dylanhmorris opened 1 month ago

dylanhmorris commented 1 month ago

Since the rendering of the pkgdown site confirms the vignette runs, we exclude running it from the Ubuntu R CMD check for efficiency, but we probably want to confirm it runs on mac and Windows.

gvegayon commented 1 month ago

Although I am all for rebuilding vignettes using different flavors of OS, I just want to ensure we all are aware of the option of sharing pre-built vignettes; see: this r-opensci article about pre-computed vignettes, the note in this section of the R pkgs book, and the section "Condition code in the code package on availability of the data package" of this paper about drat.

seabbs commented 1 month ago

We use pre-built vignettes in epinowcast etc with actions to keep them up to date. It works and is fine but its really annoying to have to store the figures etc in the repo so I would avoid if we can/for as long as possible

I wouldn't personally run the vignettes across platform and leave the unit tests for checking that but I don't think its harmful to do so.