Issue 200: Modify plot methods

CDCgov / ww-inference-model

An in-development R package and a Bayesian hierarchical model jointly fitting multiple "local" wastewater data streams and "global" case count data to produce nowcasts and forecasts of both observations

https://cdcgov.github.io/ww-inference-model/

Apache License 2.0

17 stars 2 forks source link

Issue 200: Modify plot methods #218

Closed kaitejohnson closed 4 weeks ago

kaitejohnson commented 1 month ago

This PR closes #200. This makes a few minor changes:

modifies plot of forecasted counts to not expect an evaluation dataset
adds an example in the vignette to plot without the evaluation data
replaces scales = "free" with scales = "free_y" so that the x-axis shared for the dates in the wastewater concentration plot.

@gvegayon If you think there's a better way to handle the x axis dates (or that we should exclude them) lmk. I think best to have them as a default?

github-actions[bot] commented 1 month ago

Thank you for your contribution, @kaitejohnson :rocket:! Your page is ready to preview here

gvegayon commented 1 month ago

I'm unsure about your question, @kaitejohnson, as I am no expert in ggplot2. All I can think is that I would (a) keep the detailing of the figures to a minimum or (b) ensure additional modifications are optional (e.g., add_fancy_scales = TRUE).

kaitejohnson commented 1 month ago

Well it will default to plotting the dates so they all overlap and are unreadable, which is why I added the 45 degree angle dates... I think we should leave for now bc my understanding of ggplot is that the later thing takes precedent so the user can always override