search

CDCgov / ww-inference-model

An in-development R package and a Bayesian hierarchical model jointly fitting multiple "local" wastewater data streams and "global" case count data to produce nowcasts and forecasts of both observations
https://cdcgov.github.io/ww-inference-model/
Apache License 2.0
17 stars 2 forks source link

Bug in wwvals$ww_sampled_times #226

Closed kaitejohnson closed 3 weeks ago

kaitejohnson commented 4 weeks ago

As described by @akeyel via email.

After further investigation, I believe the issue was that there were multiple site_pop per a single site being passed into wwinference. I thought that I had a check for this in preprocess_ww_data() but when I reran it didn't seem to flag.

So this issue needs to edit and retest the checkers/validate to make sure there is one unique population size per site, or add a new checker if it is missing.

gvegayon commented 4 weeks ago

I think this should be addressed in the validate_ww_conc_data() function here https://github.com/CDCgov/ww-inference-model/blob/629a9c0fe6c46f5b71fede329278cf55fcc55d99/R/validate.R#L77-L81

gvegayon commented 4 weeks ago

@kaitejohnson, besides site_pop, what other variables should be constant across sites? We should try to address the checker right away for whatever other variable needs to be considered constant.

kaitejohnson commented 4 weeks ago

It would just be that one!