CDCgov / ww-inference-model

An in-development R package and a Bayesian hierarchical model jointly fitting multiple "local" wastewater data streams and "global" case count data to produce nowcasts and forecasts of both observations
https://cdcgov.github.io/ww-inference-model/
Apache License 2.0
17 stars 2 forks source link

Modify priors on `eta_sd` and `inf_feedback` #236

Closed kaitejohnson closed 1 week ago

kaitejohnson commented 3 weeks ago

This PR addresses #227. It modifies the stan model to take in a mean of the RW step size in R(t), eta_sd, and then it tests it using the subset of forecast dates and locations set up in https://github.com/CDCgov/wastewater-informed-covid-forecasting/blob/prod/_targets_subset_benchmarking.R

Benchmarking results can be found here in the files labeled as subsets https://github.com/CDCgov/wastewater-informed-covid-forecasting/tree/205-test-out-less-informative-eta-sd/output/benchmarking. In the overall plots, the things to pay attention to are:

When we ran this on all forecast dates and location with a slightly more informative prior on eta_sd, the overall scores did look improved, though here the overall scores do not overall, if you look at the one by forecast date you see this is largely driven by 2024-01-08 as the pink (this proposed change) is an improvement most other times.

image

github-actions[bot] commented 3 weeks ago

Thank you for your contribution @kaitejohnson :rocket:! Your github-pages is ready for download :point_right: here :point_left:! (The artifact expires on 2024-11-19T19:10:48Z. You can re-generate it by re-running the workflow here.)

seabbs commented 1 week ago

No objection. The current proposal seems reasonable. We should talk about identifiability in the manuscript

kaitejohnson commented 1 week ago

Updated changelog