search

CDCgov / ww-inference-model

An in-development R package and a Bayesian hierarchical model jointly fitting multiple "local" wastewater data streams and "global" case count data to produce nowcasts and forecasts of both observations
https://cdcgov.github.io/ww-inference-model/
Apache License 2.0
16 stars 2 forks source link

2024-07-30 update : added exp decay func test. #39

Closed cbernalz closed 2 months ago

cbernalz commented 2 months ago

Before official review, @dylanhmorris and / or @kaitejohnson, how can we make a test for the auxiliary site functions or are we fine not having one for those?

kaitejohnson commented 2 months ago

Before official review, @dylanhmorris and / or @kaitejohnson, how can we make a test for the auxiliary site functions or are we fine not having one for those?

I think it would be good to have a test that shows that variance in the deviations in the auxiliary site are the same as the variance in the spatially correlated sites (so related to this week's discussion and https://github.com/cdcent/cfa-spatial-ww-internal/issues/4)

kaitejohnson commented 2 months ago

Before official review, @dylanhmorris and / or @kaitejohnson, how can we make a test for the auxiliary site functions or are we fine not having one for those?

I think it would be good to have a test that shows that variance in the deviations in the auxiliary site are the same as the variance in the spatially correlated sites (so related to this week's discussion and cdcent/cfa-spatial-ww-internal#4)

NVM forgot we were implementing with the additional parameter of a scaling factor

kaitejohnson commented 2 months ago

Tests look good. Main remaining questions are about the Rmd files, as I do think we should avoid the rstan additional dependency if possible. @cbernalz @kaitejohnson

That sounds good. I think we should just replace with that, I didn't realize that function existed.

dylanhmorris commented 2 months ago

Pending CI passes, this looks good to me

I thought we were going to replace rstan with cmdstanr before landing this?

cbernalz commented 2 months ago

Pending CI passes, this looks good to me

I thought we were going to replace rstan with cmdstanr before landing this?

@dylanhmorris I thought I replaced all of them. Can you reference where this is still the case?