search

CDCgov / ww-inference-model

An in-development R package and a Bayesian hierarchical model jointly fitting multiple "local" wastewater data streams and "global" case count data to produce nowcasts and forecasts of both observations
https://cdcgov.github.io/ww-inference-model/
Apache License 2.0
17 stars 2 forks source link

Infection feedback strength for simulated data should be configurable #65

Closed dylanhmorris closed 3 months ago

dylanhmorris commented 3 months ago

Right now it is fixed at 0. There is also an extraneous if_feedback variable that appears not to be used.

https://github.com/CDCgov/ww-inference-model/blob/142b5572e66dd09893d646a558b478985baeb900/R/generate_simulated_data.R#L229-L230

The infection_feedback value is then documented as a binary RE: whether to use, but that appears incorrect per the Stan source file. It appears it is actually the strength of the feedback. https://github.com/CDCgov/ww-inference-model/blob/142b5572e66dd09893d646a558b478985baeb900/R/generate_simulated_data.R#L299-L307

https://github.com/CDCgov/ww-inference-model/blob/142b5572e66dd09893d646a558b478985baeb900/inst/stan/functions/infections.stan#L60-L88

kaitejohnson commented 3 months ago

Ooph good catch... I can change this in #29 ?

dylanhmorris commented 3 months ago

Fixed by #29