CDK-R / cdkr

Integrating R and the CDK
https://cdk-r.github.io/cdkr/
42 stars 27 forks source link

WIP: Newsubmission #100

Closed zachcp closed 4 years ago

zachcp commented 4 years ago

@rajarshi ,

I wanted to prepare for a new submission to CRAN as stated in https://github.com/CDK-R/cdkr/issues/99. When I started to run through devtools:check() I ended up encountering a number of documentation related issues that this attempts to address. There are, as of this PR, 2 WARNINGs left (down from 5 + test fails) that deal with building the vignettes. There are a few other odds-and-ends that need to be addressed (see below) but the vignette code is the core bit that could use some work/eyes. For build_error_log see this gist.

I can keep working on this branch until the issues below are fixed, or, if you like, we can merge and tackle the issues piecemeal.

Issues Addressed in this PR

Needed Before Resubmission to CRAN

Desired before Resubmisison to CRAN

rajarshi commented 4 years ago

Started fixing the issues, but I can't get devtools::check() to run. I'm getting

** testing if installed package can be loaded
Error: package or namespace load failed for ‘rcdk’:
 object 'do' not found whilst loading namespace 'rcdk'
Error: loading failed
Execution halted

Any idea why this happens?