search

CDK-R / cdkr

Integrating R and the CDK
https://cdk-r.github.io/cdkr/
42 stars 27 forks source link

Update visual.R #27

Closed paulboardman closed 9 years ago

paulboardman commented 9 years ago

The cdk.jar file appears to be split out into many smaller jar files now. Java 6 onwards support wildcards in the classpath option. This seemed cleaner than listing and adding the full set of jars.

rajarshi commented 9 years ago

rcdklibs actually includes the 'big' jar (that bundles all the small jars), so there is technically no need for a wildcard. However this does allow us to split it up in the future if needed and not have to worry about updating class paths

paulboardman commented 9 years ago

I installed rcdk on a Mac via R-studio (using install.packages('rcdk')).

There's no cdk.jar in rcdklibs, but there are 54 indivicual cdk-*-1.5.8-SNAPSHOT.jar files. e.g. cdk-interfaces-1.5.8-SNAPSHOT.jar, cdk-atomtype-1.5.8-SNAPSHOT.jar. Hence my minor tweak.

rajarshi commented 9 years ago

D'oh! My mistake. You're correct (and this fixes a bug :). Thanks for the catch