CDK-R / cdkr

Integrating R and the CDK
https://cdk-r.github.io/cdkr/
42 stars 27 forks source link

Any change of getting stereochemistry detection? #28

Closed stanstrup closed 6 years ago

stanstrup commented 8 years ago

Seems it is included with the cdk: http://cdk.github.io/cdk/1.5/docs/api/org/openscience/cdk/stereo/Stereocenters.html what I would like to be able to do is detect which atoms are potential chiral centers.

rajarshi commented 6 years ago

Better late than never. Atom centered stereo support implemented in 553e745914

allaway commented 6 years ago

@rajarshi thanks for implementing this. I've noticed that none of the fingerprinting methods accessible in rcdk consider stereochemistry (or, I'm doing something wrong). Is this correct?

rajarshi commented 6 years ago

You're correct - none of the fingerprints were designed to consider stereo. Come to think of it I'm not sure any of the published fingerprint take into account stereo

allaway commented 6 years ago

Thanks for the confirmation! Surprising there is nothing out there.

On Wed, Mar 21, 2018, 5:27 PM Rajarshi Guha notifications@github.com wrote:

You're correct - none of the fingerprints were designed to consider stereo. Come to think of it I'm not sure any of the published fingerprint take into account stereo

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/rajarshi/cdkr/issues/28#issuecomment-375139190, or mute the thread https://github.com/notifications/unsubscribe-auth/ATdmyED1_GLJsUvydsX8gMarWM_NrMDVks5tgu_dgaJpZM4FxCOB .

rajarshi commented 6 years ago

Though I do see this as an issue with other toolkits, e.g., https://github.com/rdkit/rdkit/issues/695

It might be worth pinging the CDK list to see if there is interest in adding optional support for stereochem to the ECFP implementation

allaway commented 6 years ago

Thanks for the suggestion. I did some digging on the CDK mailing list and found a reference to this commit: https://github.com/cdk/cdk/commit/ef55233d4b5a8c0a9a3724bf5862604c7ff9e937

Looks like it should already be implemented! 💯