search

CDK-R / cdkr

Integrating R and the CDK
https://cdk-r.github.io/cdkr/
42 stars 27 forks source link

Commits since the last submission to CRAN tracking the 3.3.8 CRAN release #40

Closed zachcp closed 7 years ago

zachcp commented 7 years ago

I've updated the rcdk library to version 3.3.8 and submitted the updated package to CRAN. It has been accepted and is live. https://cran.r-project.org/web/packages/rcdk/index.html.

The main difference is that we now only require and test for Java7 and not Java 8. Now BioConductor packages and others stuck in Java7 should be okay. Initially I was going to update the rcdklibs library AND rcdk but I noticed that all of the rcdk tests passed when building with the previous rcdklibs. So I did NOT submit the rcklibs JARS but simply built the rcdk JARs as per the README using rcdklibs 1.5.13. The result was a small update without a need for a size justification and the code review was quick and easy.

I would propose waiting to update the rcdklibs jars for the 2.0 release.

Zach cp

rajarshi commented 7 years ago

Thanks for seeing this through - it's good that BioC packages can depend on rcdk. Much appreciated