search

CDLUC3 / dash

General repository for documents and communication for UC Dash project.
http://cdluc3.github.io/dash
MIT License
11 stars 4 forks source link

Facet for DataONE URL is broken #71

Closed marisastrong closed 9 years ago

marisastrong commented 9 years ago

I was just poking around UCLA's Dash site and ran into an issue

https://dash.ucla.edu/xtf/search?browse-all=yes

If I try clicking any of the links on the left-hand sidebar, there are encoding errors in the URLs so the links don't work, e.g. clicking:

Publisher •DataONE

Tries to load this URL -- note the "%2C%20dash-ucla.cdlib.org" in the URL's path.

http://dash.ucla.edu%2C%20dash-ucla.cdlib.org/xtf/search?f1-publisher=DataONE

Seems like this is the correct URL:

https://dash.ucla.edu/xtf/search?f1-publisher=DataONE

sfisher commented 9 years ago

We had a superficially similar-looking problem in WAS—not sure if it's the same though. In our case it was caused by the Apache server redirecting to the https version of the site and double-encoding when it redirected. We added NE (no encode) on the redirect. http://stackoverflow.com/questions/6520484/mod-rewrite-urlencoding-an-already-urlencoded-querystring-parameter-any-way-to

But it may not be the same problem. Just mentioning it in case it helps.

From: marisa strong notifications@github.com<mailto:notifications@github.com> Reply-To: CDLUC3/dash reply@reply.github.com<mailto:reply@reply.github.com> Date: Sunday, March 29, 2015 at 9:54 PM To: CDLUC3/dash dash@noreply.github.com<mailto:dash@noreply.github.com> Subject: [dash] Facet for DataONE URL is broken (#71)

I was just poking around UCLA's Dash site and ran into an issue

https://dash.ucla.edu/xtf/search?browse-all=yes

If I try clicking any of the links on the left-hand sidebar, there are encoding errors in the URLs so the links don't work, e.g. clicking:

Publisher •DataONE

Tries to load this URL -- note the "%2C%20dash-ucla.cdlib.org" in the URL's path.

http://dash.ucla.edu%2C%20dash-ucla.cdlib.org/xtf/search?f1-publisher=DataONE

Seems like this is the correct URL:

https://dash.ucla.edu/xtf/search?f1-publisher=DataONE

— Reply to this email directly or view it on GitHubhttps://github.com/CDLUC3/dash/issues/71.

cpwillett commented 9 years ago

Good catch. Actually, all of the facet links were broken in the UCLA Dash. We're getting two values for the header variable used to build the URL. I've filtered out one of the values; working properly now.