search

CDLUC3 / dmptool

DMPTool version of the DMPRoadmap codebase
https://dmptool.org
MIT License
58 stars 13 forks source link

Error when submitting DMP citation to ORCID #422

Closed briri closed 1 year ago

briri commented 1 year ago

The app/services/external_apis/orcid_service.rb does not have adequate nil checks.

If the project abstract is nil it results in:

ERROR -- : Either unable to register the DMP ID or unable to update the owner's ORCID record for plan 00000 /
                        and user 00000 - undefined method `encode' for nil:NilClass
ERROR -- : [
  "/apps/dmp/apps/dmptool/releases/20230112195947/app/services/external_apis/orcid_service.rb:141:in `xml_for'",   
  "/apps/dmp/apps/dmptool/releases/20230112195947/app/services/external_apis/orcid_service.rb:63:in `add_work'", 
  "/apps/dmp/apps/dmptool/releases/20230112195947/app/controllers/plans_controller.rb:445:in `mint'"
]