This upgrade includes an upgrade to the TinyMCE WYSIWYG editor and a transition from Webpacker to Jsbundling and Cssbundling! See the DMPRoadmap v4.1.0 release notes for the full details.
Developer Notes
This upgrade requires bin/rails v4:upgrade_4_0_8 to be run to seed the plans.feedback_start_at dates. Run this after bin/rails db:migrate
The newer versions of Bundler annoyingly replace the available platforms that are defined. You may see an error when deploying to your server (or building a Docker image) that states that it does not support x86_64-linux to fix that you can run bundle lock --add-platform x86_64-linux after you've run bundle install. We have also provided a bin/rails update:all rake task that will upgrade your Gem and JS dependencies and add that platform to the bundle automatically.
When running the application in development mode, you will need to run bin/dev which uses the new Procfile. This will each your SCSS and JS assets while you're working on your customizations.
Depending on how your deploy to your servers, you may need to run rails assets:clobber before running rails assets:precompile. Capistrano for example uses a shared public/assets/ directory. This will ensure that Rails does not try to use an old Webpacker generated application.css and application.js files
If you have placed custom CSS in a separate directory under app/assets/stylesheets/, you will need to add an _index.scss file to that directory and@use your sass files in that index. Here is a good video about SAS @use vs @import: https://www.youtube.com/watch?v=CR-a8upNjJ0
If you use the color or other sass variables in your custom css files, you will need to add the following line to the top of your file: @use '../variables/colours' as *; (you may need to adjust the relative path to work with the location of your file)
The location of the application.scss and application.js files have changed. If you were importing custom code into either of these, you will need to re-add your imports.
The way that the JS and CSS files are imported into the app/views/layouts/application.html.erb have changed. If you have a custom app/views/branded/layouts/application.html.erb you will need to update it to the new tag.
Changes proposed in this PR:
Update to the Org admin Plans page that will now show the date that feedback was requested. #434
Changed the language around the confusing checkbox/option text on the download plan page (for PDF download) and changed defaults so that only the section heading and question text are enabled by default. #435
Fixed an issue causing the mouse pointer to change to a text icon when hovering over hyperlinks for Chrome and Firefox. It now correctly displays the hand pointer issue #445
Patch issue #447 that was deleting all prior related identifiers when a user adds a new related identifier on the 'Follow up' tab.
Patch Github Actions to lock Node at v16.6 to deal with a version compatability issue with openSSL
Attempt to patch issue that was causing registry_orgs search by name to fail for Postgres distributions that is causing Rspec tests to fail for spec/services/api/v2/deserialization/*.rb. Perhaps someone out there with Postgres can debug, fix and submit a PR.
This upgrade includes an upgrade to the TinyMCE WYSIWYG editor and a transition from Webpacker to Jsbundling and Cssbundling! See the DMPRoadmap v4.1.0 release notes for the full details.
Developer Notes
bin/rails v4:upgrade_4_0_8
to be run to seed theplans.feedback_start_at
dates. Run this afterbin/rails db:migrate
x86_64-linux
to fix that you can runbundle lock --add-platform x86_64-linux
after you've runbundle install
. We have also provided abin/rails update:all
rake task that will upgrade your Gem and JS dependencies and add that platform to the bundle automatically.bin/dev
which uses the new Procfile. This will each your SCSS and JS assets while you're working on your customizations.rails assets:clobber
before runningrails assets:precompile
. Capistrano for example uses a sharedpublic/assets/
directory. This will ensure that Rails does not try to use an old Webpacker generated application.css and application.js filesapp/assets/stylesheets/
, you will need to add an_index.scss
file to that directory and@use
your sass files in that index. Here is a good video about SAS@use
vs@import
: https://www.youtube.com/watch?v=CR-a8upNjJ0@use '../variables/colours' as *;
(you may need to adjust the relative path to work with the location of your file)application.scss
andapplication.js
files have changed. If you were importing custom code into either of these, you will need to re-add your imports.app/views/layouts/application.html.erb
have changed. If you have a customapp/views/branded/layouts/application.html.erb
you will need to update it to the new tag.Changes proposed in this PR:
spec/services/api/v2/deserialization/*.rb
. Perhaps someone out there with Postgres can debug, fix and submit a PR.