Write feature tests for new UI features

[terrywbrady]

Controller Tests

• Template
• ResearchOutput

Model Tests

• Template
• TemplateOutputType
• TemplateRepository
• TemplateMetadataStandard
• TemplateLicense
• (Custom) Repository
  • UI uses template -> custom repository
  • UI does not use inverse custom repository -> template. Test needed

Feature Tests

Excellent! Yes, some feature tests would be good. You can create one at spec/features/research_outputs_spec.rb and use the modal_search_spec.rb in that directory as a model. I have tests for the repository selection workflow in that test

• Preferences screen: https://github.com/CDLUC3/dmptool/blob/v4.1.0-beta/spec/features/templates_spec.rb
  • [x] editable for org admin
  • [ ] editable when able to customize a funder template
  • [x] read only for prior versions of a template
  • behaviors
  • [x] enable RO
  • [x] disable RO
  • [x] Use Standard Output Types
  • [x] Prefer My Output Types
  • [x] Prefer Standard + My Output Types
  • [x] Attempt to add a duplicate output type
  • [x] Use standard repositories
  • [x] Use preferred repositories
  • [x] Use custom repositories
  • [x] Attempt to create custom repository with missing data
  • [ ] Attempt to create duplicate custom repository (no logic currently prevents this)
  • [x] Use standard metadata standards
  • [x] Use preferred metadata standards
  • [x] Use standard licenses
  • [x] Use preferred licenses
  • [x] Attempt to add duplicate license
  • [x] Create string tooltip for Output type fields
  • [ ] Create html tooltip for Repositories
  • [ ] Create html tooltip for Metadata Standards
  • [ ] Create string tooltip for Licenses
• Research Outputs
  • [ ] RO enabled for template
  • [ ] RO disabled for template
  • [ ] RO exists for template with RO disabled, ensure that the RO tab is still accessible (note, this may no longer be feasible once the versioning is in place for template preferences)
  • [ ] Selectable standard output types
  • [ ] Selectable preferred output types
  • [ ] Selectable standard repositories
  • [ ] Selectable preferred repositories
  • [ ] Selectable standard and custom repositories
  • [ ] Selectable preferred and custom repositories
  • [ ] Selectable standard metadata standards
  • [ ] Selectable preferred metadata standards
  • [ ] Selectable standard licenses
  • [ ] Selectable preferred licenses
  • [ ] View string tooltip for Output type fields
  • [ ] View html tooltip for Repositories
  • [ ] View html tooltip for Metadata Standards
  • [ ] View string tooltip for Licenses